-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use qualified method name for calls to Kernel#load #1503
Conversation
This is primarily intended to fix the issue identified in asciidoctor/asciidoctor#3623. |
To be consistent with calls elsewhere in the library, I think the dot-notation syntax for a static method should be used instead: |
I think it's fine as it is. |
LGTM, @pyrmont, merge as you like :] |
I can't really see a material difference but it does seem more semantically correct to call |
Of course you know about the following better than I do, but leaving a comment just in case you overlook them.. rouge/lib/rouge/lexers/gherkin.rb Lines 20 to 24 in 2b704db
|
Thanks Ash! Will make sure to include those as well :) |
One thing we've learned from the incident that led to this request is that the top-level |
Thanks everyone. Got this merged in. In terms of pushing it out in a gem, my plan is to release this as part of the other updates coming in v3.19.0. On our monthly cadence, that's scheduled for release on Tuesday 12 May. |
Rouge currently loads various components of the library using `Kernel#load`. In certain conditions, this can cause issues where `load` is redefined at the global level. To ensure maximum compatibility with other libraries, this commit replaces all calls to `load` with qualified calls to `Kernel::load`. It also updates one call to `Object.send` with a call to `Object::send` for consistency.
Rouge loads various components of the library using
Kernel#load
. In certain situations, this can cause issues whereload
is redefined at the global level. To ensure maximum compatibility with other libraries, this PR replaces all calls ofload
with qualified calls toKernel::load
.